Update Log 10/08/2022 - Lag Fix Attempt 1

[Nate]

Delete Jamie’s inventory, might do the job hopefully

 

[Tetra]

Who the fuck has 10k newspaper

 

[flux]

i can confirm that my fps has improved since this update! thank you fredy

 

[jozhhill]

0/10 update.

brother still banned.

 

[Efan]

0/10 update.

brother still banned.

 

[Google Chrome]

0/10 update.

brother still banned.

Don't care + ratio

 

[orzel1244]

Well, I don't understand point of "50 packs of 200 cocaine" instead of 1 pack of 10,000 coca, can you explain that? Also, if this kind of change affects your server's RAM usage, it means you need to distribute the memory a bit better, have you considered using Redis? It is a reliable and scalable key:value database in-memory value.

Professionally I create a large video and chat streaming platform, I know something about optimization, I will be happy to help if you need it.

 

[Fredy]

It's not immediately an issue with RAM, it's an issue with Garry's Mod's garbage collector. This update fixes that by reducing the number of live objects simultaneously. This essentially divides items used by drugs by 200, thus massively speeding up the garbage collector.)

Redis would not help at all in this case, we do already have a database that is _very_ fast, but we also cache all items of players on the server in the server's ram. Changing this would be the ideal solution, but would both slow down accessing inventories significantly and take a long time to change the code.

 

[Bnjemann]

Well, I don't understand point of "50 packs of 200 cocaine" instead of 1 pack of 10,000 coca, can you explain that? Also, if this kind of change affects your server's RAM usage, it means you need to distribute the memory a bit better, have you considered using Redis? It is a reliable and scalable key:value database in-memory value.

Professionally I create a large video and chat streaming platform, I know something about optimization, I will be happy to help if you need it.

Because that would allow players to sell 1.5 Million worth of cocaine maybe? If the drug limit was kept at 15, this would allow users to sell 22500000 worth of cocaine at once if they were to get that much cocaine (Which is doable)

 

[orzel1244]

It's not immediately an issue with RAM, it's an issue with Garry's Mod's garbage collector. This update fixes that by reducing the number of live objects simultaneously. This essentially divides items used by drugs by 200, thus massively speeding up the garbage collector.)

Redis would not help at all in this case, we do already have a database that is _very_ fast, but we also cache all items of players on the server in the server's ram. Changing this would be the ideal solution, but would both slow down accessing inventories significantly and take a long time to change the code.

Well, I can't agree that it's gmod issue, the issue is that you're storing items in wrong way, even if the GC would work better - at some point you'd have similar issue

I don't know how you store such items, but for instance
It's more expensive to have
{id: 1, owner: 2137, name: "Coke"}
{id: 2, owner: 2137, name: "Coke"}
{id: 3, owner: 2137, name: "Coke"}
{id: 4, owner: 2137, name: "Coke"}
... and 9996 more items allocated
than
{id: 1, value: 10000, owner: 2137, item_id: 22}
If you need to perform actions such as selling, dragging and etc - you can implement it somewhere else, the domain side (logic) of project shouldn't be affected of how data is being stored according to DDD which is great approach for delivering reliable software

@Bnej It can be fixed in several ways, you can make drug dealer be able to buy only x of drug, you bring him 1 item of 10.000 coke, and he says you that he can take only 2000g at this time from you.

 

[Fredy]

I don't know how you store such items, but for instance
It's more expensive to have
{id: 1, owner: 2137, name: "Coke"}
{id: 2, owner: 2137, name: "Coke"}
{id: 3, owner: 2137, name: "Coke"}
{id: 4, owner: 2137, name: "Coke"}
... and 9996 more items allocated
than
{id: 1, value: 10000, owner: 2137, item_id: 22}

The first way of storing items is the "correct" way, especially in a database (except for storing the name on every object).

• It allows for tracking exactly what happens to which item in the logs.
• It prevents duplication glitches since an item can only be in one inventory at a time
• It allows for restoring specific items and saving specific items to be restored (notice how no other gmod server has a restore system like ours)
• It allows for storing specific properties for each item. Each of our guns has several properties, such as fire select mode and bullet count. Drugs like meth have purity associated with them

And as I said, this is absolutely an issue with the Lua GC since it is incredibly outdated and does not run concurrently with the application. Instead, it requires pauses after each tick to mark garbage and a big pause after each cycle to free and finalize dead objects. A modern GC (especially a generational one), would have 0 issues with the number of objects on our server.

The best fix, as I already said, would be to not store all these items in the server's ram but to keep them in the database. But it would be too significant of a change.

By the way, the "hack" for cocaine and weed is precisely what you describe. Instead of storing each cocaine item individually, an item now has a count property for how many packs of drugs are in it.

 

[orzel1244]

Oh well, didn't thought about tracking each item, I understand the decision now, well hopefully we will migrate to S&Box soon

 

[Jack Bruhross]

Touch my pots I’ll kill you @Fredy

 

[Fredy]

Touch my pots I’ll kill you @Fredy

Oh no, he doesn't know yet

 

[Max]

Oh no, he doesn't know yet

I had to run to check on my babies..... false alarm guys do not feed the trolls

 

[Jimmy Bovine]

It does boggle the mind how people can hoard so much stuff

 

[Google Chrome]

where is the chess update

 

[Clarky]

It does boggle the mind how people can hoard so much stuff

 

[rxsm]

 

[Clarky]

View attachment 15793